max-kamps / jpd-breader

MIT License
102 stars 28 forks source link

Add mobile support #17

Open max-kamps opened 1 year ago

max-kamps commented 1 year ago

Not sure what does and doesn't work on mobile right now. I would imagine the following might not work:

TheInvincible95 commented 1 year ago

I attempted to install version 0.0.4 on Kiwi Browser Version 107.0.5304.74 As you expected, context menu to parse selected text didn't work. On ttu reader, I got the text colouring for the automatic parse, but no Furigana (both in Vartical and Horizontal text mode). Tapping on a word selected it (underline), but there was no popup.

Additional stuff:

Edit: Furigana works, I just had it off in ttu settings so it didn't render. Screenshot_20230322_175932_Kiwi Browser

TheInvincible95 commented 1 year ago

I just noticed an error in kiwi://extensions that wasn't there when I installed.

Unchecked runtime.lastError: 
Cannot access contents of url "chrome-extensions://<ID>/settings_page/settings.html". 
Extension manifest must request permission to access this host.
Context
background/background.html
Stack Trace
background/background.html:0 (anonymous function)
AleMax commented 1 year ago

Version 0.0.2: image Coloring works; Popup generally works (without hotkey), positioning and sizing borked. This is how Yomichan wraps it: image

Version 0.0.5 (currently newest): Nothing works anymore, coloring does not work on any site, popup obviously neither (because i cant press a hotkey) image

Edit: Nevermind, i used the borked Chrome Version of 0.0.5, after installing the newest zip the coloring works again, so ignore what i said.

AleMax commented 1 year ago

Coloring does not work on the mobile japanese wikipedia (ja.m.wikipedia), only on the browser version (jp.wikipedia)

Also, while using the Desktop site, there is something very buggy going on when clicking on a word: image

Might need a good idea on what to do with links on websites like Wikipedia that would trigger if you click on them to see the popup

TheInvincible95 commented 1 year ago

More error messages:

[object Object]
Context
https://reader.ttsu.app/b?id=6
Stack Trace
content/content.js:267 (anonymous function)
Uncaught (in promise) # <Object>
Context
https://reader.ttsu.app/b?id=6
Stack Trace 
content/ttu.js:53 (anonymous function)

I'm not sure how to reproduce these, I was just adjusting settings in ttu reader.

TheInvincible95 commented 1 year ago

When I reloaded the extension:

disconnect [object Object]
Context
settings_page/settings.html
Stack Trace
content/content.js:257 (anonymous function)
7w1 commented 1 year ago

Seems like websites added to the home screen aren't tabs. When clicking the extension, they don't appear under "Parse currently open tabs:" Custom word css doesn't work in them. The popup css works fine though.

Kiwi Browser version 112.0.5615.137 Extension version 12.1

Kiwi Browser Error Message