search

max-kamps / jpd-breader

MIT License
100 stars 25 forks source link

Add integration with itazuraneko #29

Closed Helmasko closed 1 year ago

Helmasko commented 1 year ago

As the title says it, add support for the novel section of itzuranekko like for the ttsu app. Right now when you try selecting all the text to parse, you either get: text too long, Error: Cannot read properties of undefined (reading 'parentNode'), or I remember getting something about reaching end of document.

max-kamps commented 1 year ago

These bugs with the right click selection parsing should be fixed now, hopefully :+1:

Currently I don't think I'll be adding integration for Itazuraneko. For the full reasoning, you can see the pull request from mikzorz, but TL;DR Integrations should only be used for websites that actually need it (IMO), rather than for avoiding bugs, and I also don't want to add integrations for piracy websites.