search

max-kamps / jpd-breader

MIT License
100 stars 24 forks source link

Added Itazuraneko integration #38

Closed mikzorz closed 1 year ago

mikzorz commented 1 year ago

29

Tested on chrome.

max-kamps commented 1 year ago

I've been hemming and hawing about this pull requests since coming back to development a week ago... Don't think I can accept this.

First, I think integrations should be reserved for websites that need it for technical reasons (for example, because they dynamically add elements at runtime in a way that would be too annoying to right-click-parse every time.) As far as I can tell, this is not the case with this website. I know "Ctrl-A right-click parse" is annoying to some people, so in the future I will try to add a feature that lets you register URLs to parse automatically in the settings, if browsers allow this. If it turns out to be impossible, I might change my mind about this. I can also see there are some complaints in the original issue about "text too long" and "reached end of document" error messages. These have since been fixed. I don't think integrations should be added as a way of papering over bugs.

Secondly, I don't really feel comfortable adding integrations for piracy resources. Itazuraneko also has some public domain works, but its primary purpose seems to be piracy.

mikzorz commented 1 year ago

No problem, thanks for the feedback!