max-kamps / jpd-breader

MIT License
102 stars 28 forks source link

Support for youtube video subtitles #56

Closed xyaman closed 1 year ago

xyaman commented 1 year ago

This adds support for in-video subtitles and also works with ASR. The code is still messy, but it works. I'm just sharing it here so that other people can maybe help as well.

While non-ASR subtitles work perfectly, there are some issues with ASR.

Current limitations:

TODO:

max-kamps commented 1 year ago

Might be good idea to split the code, I had some problems with the extension when I tried ('export' not defined), maybe someone else can figure it out.

Should probably improve the error message for that... :smile: If you want to split part of a content script into a separate file, you need to make that file a normal module (i.e. remove the // @reader content-script comment.) Like how integrations/common.ts does it.