search

max-mapper / elementary-electron

NodeSchool workshop for learning Electron
228 stars 44 forks source link

added ', webPreferences: {nodeIntegration: true}' to the variable def… #34

Open BackgroundLogic opened 5 years ago

BackgroundLogic commented 5 years ago

added ', webPreferences: {nodeIntegration: true}' to the variable defining the new electron window, node integration is false in electron 5.0.0+ by default, due to this require is not defined

lporras commented 5 years ago

@BackgroundLogic I think you would have to upgrade the package version...

kasinathps commented 5 years ago

added ', webPreferences: {nodeIntegration: true}' to the variable defining the new electron window, node integration is false in electron 5.0.0+ by default, due to this require is not defined

Worked for me. Thanks :) 👍

arnitkun commented 5 years ago

I was not able to import 'cat-picture' without this. Just putting this here for the future.

Julix91 commented 4 years ago

I came here to make this PR, only to find out it already exists :D

Found the issue had already been reported https://github.com/maxogden/elementary-electron/issues/3 and the PR already posted.

Could we get this merged, please? :) @maxogden @zeke ? or who's the maintainer now?