max-mapper / extract-zip

Zip extraction written in pure JavaScript. Extracts a zip into a directory.
BSD 2-Clause "Simplified" License
391 stars 127 forks source link

add electron mac, linux and windows zips as test cases #11

Open max-mapper opened 9 years ago

max-mapper commented 9 years ago

https://github.com/maxogden/extract-zip/issues/10 was caused by not testing the linux and windows electron zips, we should add them to the test suite. I tested the mac one manually but it should get added too

I don't mind the test suite of this having to download the 100mb+ needed for this issue if it means more stability

I think the tests should extract them, and then test that certain files were created. I'm not sure exactly which files to test yet, but if someone wants to tackle this, just start with something basic