search

max-mapper / extract-zip

Zip extraction written in pure JavaScript. Extracts a zip into a directory.
BSD 2-Clause "Simplified" License
388 stars 126 forks source link

dry-run when opts.dir is null; zipfile entry output stream creation function #28

Closed nkocic closed 4 years ago

max-mapper commented 7 years ago

hi sorry for the delayed response. I like the dry run options but it needs docs and tests.

for the createwritestream option I dont like the pattern of passing it as a 4th argument. I would rather have it be opts.createWriteStream. additionally I don't like the use of large ternary operator lines, and this would needs docs and tests as well

malept commented 4 years ago

Closing as this is way out of date and needs a lot of work.