search

max-mapper / extract-zip

Zip extraction written in pure JavaScript. Extracts a zip into a directory.
BSD 2-Clause "Simplified" License
388 stars 126 forks source link

Add support for Node.js version 0.10 #51

Closed jugglinmike closed 6 years ago

jugglinmike commented 6 years ago

Hi there,

A project I maintain relies on this package transitively through the phantomjs-prebuilt package. Recently, we started seeing failures on our Windows build for Node.js 0.10 because of this project's relatively new reliance on path.isAbsolute (a built-in method that introduced in Node 0.11).

Node 0.10 is very old, but this seems like a very minor detail for me to drop support. I can see from this project's history that it never explicitly supported that version of Node, but I figured that because the fix is so trivial, it would be worth at least asking if you folks wouldn't mind taking on the maintenance burden.

Thanks for your consideration!

jugglinmike commented 6 years ago

@maxogden @malept Any thoughts on this?

malept commented 6 years ago

Personally, I do not want to commit to supporting EOL'd Node versions. If it were up to me, I would actually go the other way and drop support for 0.12 and iojs, because the test matrix is way too big for the number of maintainers (given the number of projects that depend on this).