search

max-mapper / extract-zip

Zip extraction written in pure JavaScript. Extracts a zip into a directory.
BSD 2-Clause "Simplified" License
391 stars 127 forks source link

Fix for #6 (empty directories are not created) #9

Closed smebberson closed 9 years ago

smebberson commented 9 years ago

This PR does:

@maxogden, this is now complete.

max-mapper commented 9 years ago

awesome, looks good and glad it turned out to be pretty straightforward. gonna merge and then add https://www.npmjs.com/package/standard style

smebberson commented 9 years ago

@maxogden, cool. I tried to follow that (not in test/test.js) but that isn't the usual style guide that I follow so I'm unpractised at it.

smebberson commented 9 years ago

@maxogden, oh, please let me know when you've published to npm. Thanks!

max-mapper commented 9 years ago

@smebberson will do. found a regression which is that now that we aren't calling mkdirp on every entry, it fails if the initial target folder doesn't exist with a 'directory does not exist' error when it tries to extract the first file in the zip. fixing now

smebberson commented 9 years ago

@maxogden, sorry about that! At least you can easily write a test for it now :)

max-mapper commented 9 years ago

@smebberson hah, true. published as 1.1.0. check out the last couple of commits for the fix i made if youre interested. thanks again