Fix pipeline promise that never resolves on Node 14

max-mapper / extract-zip

Zip extraction written in pure JavaScript. Extracts a zip into a directory.

BSD 2-Clause "Simplified" License

388 stars 126 forks source link

Fix pipeline promise that never resolves on Node 14 #98

Closed aduh95 closed 4 years ago

aduh95 commented 4 years ago

There is probably some breaking change in the promisified version of pipeline in Node.js 14.0.0; as a workaround, this PR add a listener to the end event of the ReadableStream to avoid the dead-lock.

Fixes: https://github.com/maxogden/extract-zip/issues/94

aduh95 commented 4 years ago

Node.js 14.1.0 has been released with a fix for the linked issue. Probably not worth landing this hack.