search

max-mapper / filereader-stream

Read an HTML5 File object (from e.g. HTML5 drag and drops) as a stream.
BSD 2-Clause "Simplified" License
102 stars 18 forks source link

File.lastModifiedDate is deprecated. Use File.lastModified instead. #15

Closed jakeburden closed 6 years ago

jakeburden commented 6 years ago

Calling file.lastModifiedDate shows a warning in the Firefox console now:

File.lastModifiedDate is deprecated. Use File.lastModified instead.

This PR:

neftaly commented 6 years ago

My vote is for a breaking change, that outright replaces lastModifiedDate with lastModified :)

jakeburden commented 6 years ago

@neftaly I agree that a semver update to 2.0.0 and removing lastModifiedDate completely is a sensible approach. MDN does recommend updating existing code to use lastModified. I'll push an update in a few hours as it's still very early here (4am) :smile:

jakeburden commented 6 years ago

Updated PR to replace lastModifiedDate with lastModified completely and with a major version bump

neftaly commented 6 years ago

I think @maxogden might want to bump the actual version themselves? It's probably worth merging the older and newer commit into one, too!

jakeburden commented 6 years ago

@neftaly Thank you so much for the advice! I've reverted my change to the version number and merged all commits as one. (Did a soft reset, re-committed, then force pushed.)

neftaly commented 6 years ago

if I dont respond to your PR you should send me a DM on twitter

Looks like max isn't active on SSB anymore. Do you have twitter? Can you send a DM if there's no response in the next few days?

jakeburden commented 6 years ago

woot 🎉 merged and bumped! thank you @maxogden for adding me to the repo and @neftaly for the help!