search

max-mapper / filereader-stream

Read an HTML5 File object (from e.g. HTML5 drag and drops) as a stream.
BSD 2-Clause "Simplified" License
102 stars 18 forks source link

Use streams2? #5

Closed feross closed 9 years ago

feross commented 10 years ago

I'm not super familiar with how to work with old streams. This module doesn't seem to emit data events, which all streams should do. Listening for the readable event obviously doesn't work because that's streams2 only. It seems like pipe is the only thing that will work.

Would you accept a PR that ported this to use streams2?

max-mapper commented 10 years ago

yep!

feross commented 10 years ago

I found https://www.npmjs.org/package/filestream which seems to work just fine so I'm using that for now.

adius commented 9 years ago

Yeah, this module is fundamentally flawed. You should write a warning in the readme and redirect to https://github.com/DamonOehlman/filestream

adius commented 9 years ago

Why are you closing this? Even without a comment. This is not a stream. It's just an event-emitter which happens to implement a pipe method. You should inform potential users about this!

konklone commented 9 years ago

Dude's under no obligation to do anything. It's an open source project, and a small one. Spend your energy making things.