search

max-mapper / geojson2rtree

generate a static rtree (using terraformer) from a set of geojson features
9 stars 0 forks source link

use rtree directly #2

Open calvinmetcalf opened 10 years ago

calvinmetcalf commented 10 years ago

it supports geojson

max-mapper commented 10 years ago

Oh, does it use JSONStream or JSON.parse?

On Friday, April 11, 2014, Calvin Metcalf notifications@github.com wrote:

it supports geojson

— Reply to this email directly or view it on GitHubhttps://github.com/maxogden/geojson2rtree/issues/2 .

calvinmetcalf commented 10 years ago

neither you can pass it a geojson object via it's geoJSON method, supports Features, FeatureCollections, and arrays of Features

max-mapper commented 10 years ago

the nice thing about JSONStream is that large json input streams can start getting added to the rtree immediately (streaming). can you link me to the source of the geoJSON method you mentioned?

calvinmetcalf commented 10 years ago

https://github.com/leaflet-extras/RTree/blob/master/lib/geojson.js#L138

On Fri, Apr 11, 2014 at 1:42 PM, Max Ogden notifications@github.com wrote:

the nice thing about JSONStream is that large json input streams can start getting added to the rtree immediately (streaming). can you link me to the source of the geoJSON method you mentioned?

Reply to this email directly or view it on GitHubhttps://github.com/maxogden/geojson2rtree/issues/2#issuecomment-40229889 .

-Calvin W. Metcalf

JerrySievert commented 10 years ago

that's the leaflet rtree implementation, which is slightly different than the one that terraformer provides (though from the same base code, i believe).

calvinmetcalf commented 10 years ago

its not from leaflet, it's just in that org, the author of the original one abandoned it so this repo is where I forked to to to fix some bugs, add geojson, and publish to npm.

On Fri, Apr 11, 2014 at 2:01 PM, Jerry Sievert notifications@github.comwrote:

that's the leaflet rtree implementation, which is slightly different than the one that terraformer provides (though from the same base code, i believe).

Reply to this email directly or view it on GitHubhttps://github.com/maxogden/geojson2rtree/issues/2#issuecomment-40235577 .

-Calvin W. Metcalf

JerrySievert commented 10 years ago

that's pretty much the same thing that happened for the terraformer-geostore-rtree, except we added the check to insert and added within.