fix: Avoid setVisibleOnAllWorkspaces from destroying the original visible state of app.dock

max-mapper / menubar

➖ high level way to create menubar desktop applications with electron

BSD 2-Clause "Simplified" License

6.64k stars 363 forks source link

fix: Avoid setVisibleOnAllWorkspaces from destroying the original visible state of app.dock #442

Closed 1zilc closed 8 months ago

1zilc commented 1 year ago

Due to this code change https://github.com/electron/electron/pull/37599/files , setVisibleOnAllWorkspaces(true) has changed its original logic, resulting in the reappearance of the already hidden dockIcon. This change avoids the occurrence of this phenomenon The affected versions include 23.2.x 24.x.x

amaury1093 commented 8 months ago

Thanks!