search

max-mapper / nugget

minimalist wget clone written in node. HTTP GET files and downloads them into the current directory
BSD 3-Clause "New" or "Revised" License
167 stars 30 forks source link

errror on 300 or higher, #1

Open calvinmetcalf opened 9 years ago

calvinmetcalf commented 9 years ago

the only time you'd care about a 300-399 would be a 304 right? (maybe a 300 but I don't see that one very often), upon first read it sounded like I had to do manual redirects.

max-mapper commented 9 years ago

yea you're probably right here, I think the status code handling could be better for sure

max-mapper commented 9 years ago

update: it uses request which handles most redirects for you. but if request returns a >299 statusCode to the final callback then nugget will stop. open to suggestions on better behavior

calvinmetcalf commented 9 years ago

oh I was just going to suggest updating the readme

On Mon, Oct 20, 2014 at 12:04 AM, Max Ogden notifications@github.com wrote:

update: it uses request which handles most redirects for you. but if request returns a >299 statusCode to the final callback then nugget will stop. open to suggestions on better behavior

— Reply to this email directly or view it on GitHub https://github.com/maxogden/nugget/issues/1#issuecomment-59681545.

-Calvin W. Metcalf