search

max-mapper / screencat

:cat2: webrtc screensharing electron app for mac os (Alpha)
http://maxogden.github.io/screencat
BSD 2-Clause "Simplified" License
3.02k stars 370 forks source link

Sharing a specific window / area #37

Open Ivshti opened 9 years ago

Ivshti commented 9 years ago

Sharing a specific window or an area would be a nice capability - chromium has it as a functionality, as it uses it for chromecasting.

By initial research, I assume this happens by setting chromeMediaSource to "desktop" and chromeMediaSourceId to a value returned by chooseDesktopMedia - https://developer.chrome.com/extensions/desktopCapture.

max-mapper commented 9 years ago

technically that is not implemented in chromium but in chromes 'chrome app' libraries, I opened an issue requesting support for it in electron a while back https://github.com/atom/electron/issues/1380

TheSisb commented 8 years ago

Recently got merged into Electron (screen/window) https://github.com/atom/electron/pull/2963

max-mapper commented 8 years ago

OH NICE FINALLY!!!

max-mapper commented 8 years ago

Docs for it are here: https://github.com/atom/electron/blob/9c861b9ad37a9c6335dde2e59d3005742fe75150/docs/api/desktop-capturer.md

This will let us implement a UI that asks the user what part of the screen they want to share. Currently we only share the entire screen. Being able to select only 1 screen would be pretty sweet :)

max-mapper commented 8 years ago

got it working in https://github.com/maxogden/screencat/commit/9e93952e8f5c1c3f714636d1b47acb447602f51b

heres the UI I hacked up:

screen shot 2015-12-15 at 2 12 16 pm

because of the way it changes screen sharing, audio chat is currently not hooked up. I'll need to hook that up again with more code

feedback welcome!

TheSisb commented 8 years ago

LGTM

Raj123456788 commented 8 years ago

Can anyone please answer this question: https://github.com/atom/electron/issues/4432