max-mapper / screencat

:cat2: webrtc screensharing electron app for mac os (Alpha)
http://maxogden.github.io/screencat
BSD 2-Clause "Simplified" License
3.02k stars 370 forks source link

Use RobotJS from npm. #38

Closed octalmage closed 9 years ago

octalmage commented 9 years ago

Now that we have modifiers implemented, ScreenCat can use the official RobotJS build. This build includes Linux support and Windows support will be done in a few weeks.

3.

octalmage commented 9 years ago

Just want to add that the Windows build has been out for a few weeks and it's working great!

brandly commented 9 years ago

Looks like RobotJs v0.2.4 is out now. (I'm sure you know this :smile:)

I'm having trouble running screencat from source though. It looked like RobotJS was throwing, so I pointed it at ^0.2.4. It still threw on install. Here's the output.

If I directly clone RobotJS and npm install, it seems to install smoothly tho. Any idea what I'm doing wrong?

Update: screencat appears to working, without RobotJS installing. I guess that's why it's an optional dependency

Update 2: some things are definitely breaking, due to not finding RobotJS

Update 3: Since a clone and npm install or RobotJS seems to work fine, I copied that into the screencat/node_modules folder, and now everything seems to run. I have no idea why it won't install as a screencat dep.

max-mapper commented 9 years ago

hmm maybe the code published to robotjs on npm is different from the code in the git repo...

octalmage commented 9 years ago

Node.js v4 isn't supported by the RobotJS version published to npm, but the version on GitHub has been updated. I'll be publishing a new version soon.

octalmage commented 9 years ago

A ton of things changed internally with Node.js v4 and nan v2, so it required a rewrite.

octalmage commented 9 years ago

@brandly try now! RobotJS v0.3.0 was released with Node.js v4 support.

brandly commented 9 years ago

looks great!! thanks, @octalmage

octalmage commented 9 years ago

@brandly no problem! Thanks for testing!

octalmage commented 9 years ago

@maxogden this is good to merge! This will add both Windows and Node.js v4 support.

max-mapper commented 9 years ago

OK awesome

max-mapper commented 9 years ago

Nice, works a charm!

max-mapper commented 9 years ago

published a new release https://github.com/maxogden/screencat/releases/tag/v3.0.0 if anyone can build + test windows and mac binaries let me know and I can upload them!

octalmage commented 9 years ago

Awesome! I'll work on a Windows build later today.

chenkaigithub commented 8 years ago

@maxogden I want to test windows! Thank you!

max-mapper commented 8 years ago

@chenkaigithub hi, thanks :) I just realized I don't have a way to build a release for windows, because I don't have a windows computer at the moment.

Could you try building it? You will need Visual studio C++ installed so you can build the native modules. Here are instructions for cmd.exe:

git clone https://github.com/maxogden/screencat.git
cd screencat
npm install
npm install electron-rebuild
.\node_modules\.bin\electron-rebuild.cmd
npm start

If any of those fail, can you share the error messages?

chenkaigithub commented 8 years ago

Hi Maxogen, I built and test Windows version,it's workable! Great! On Thu, Dec 31, 2015 at 3:59 AM maxogden notifications@github.com wrote:

@chenkaigithub https://github.com/chenkaigithub hi, thanks :) I just realized I don't have a way to build a release for windows, because I don't have a windows computer at the moment.

Could you try building it? You will need Visual studio C++ https://github.com/nodejs/node-gyp installed so you can build the native modules. Here are instructions for cmd.exe:

git clone https://github.com/maxogden/screencat.git cd screencat npm install npm install electron-rebuild .\node_modules.bin\electron-rebuild.cmd npm start

If any of those fail, can you share the error messages?

— Reply to this email directly or view it on GitHub https://github.com/maxogden/screencat/pull/38#issuecomment-168064718.

max-mapper commented 8 years ago

@chenkaigithub wow cool, can you run two at once and screenshare with yourself? if you get it working can you send a screenshot?

chenkaigithub commented 8 years ago

Sure! I willl send screenshots later!

On Thu, Dec 31, 2015 at 8:24 AM maxogden notifications@github.com wrote:

@chenkaigithub https://github.com/chenkaigithub wow cool, can you run two at once and screenshare with yourself? if you get it working can you send a screenshot?

— Reply to this email directly or view it on GitHub https://github.com/maxogden/screencat/pull/38#issuecomment-168099474.

octalmage commented 8 years ago

Sorry forgot about this, let me know if you need anything!

chenkaigithub commented 8 years ago

screenshot1

screen shot 2015-12-31 at 10 11 18 am
max-mapper commented 8 years ago

@chenkaigithub WOW!!! So awesome! Thanks for testing, that is really cool

octalmage commented 8 years ago

Woohoo! This is awesome!