max-mapper / torrent

download torrents with node from the CLI
https://www.npmjs.org/package/torrent
634 stars 78 forks source link

Add a copy of the BSD 2-Clause license #35

Closed Calinou closed 3 years ago

Calinou commented 9 years ago

It is good practice to add a copy of the license to the repository.

(Note: I saw the license of the project here.)

LinusU commented 9 years ago

Why is it good practice? It's specified in the package.json file.

Calinou commented 9 years ago

See Do I really need to include a licence file for common licences like GPL or MIT?. In short, it avoids legal uncertainty.

The next step would be to add a licensing header at the top of each code file (in case the file is separated from the base repository, eg. when it is put on a paste bin), but it's more complicated.

LinusU commented 9 years ago

Yuck, I hate having license information in the top of each file :(

Personally I would probably skip it on the grounds that I'm lazy, but it'll be up to @maxogden to decide how he wants to do.

On a semirelated note, githubs choosealicense.com recommends the ISC license instead and says that:

The ISC license is functionally equivalent to the BSD 2-Clause and MIT licenses, removing some language that is no longer necessary.

Maybe we should use that one instead? The text is shorter \o/

Calinou commented 9 years ago

choosealicense.com recommends MIT more than ISC.

If you are going to change the license, I recommend you pick MIT.

LinusU commented 9 years ago

Hmm, interesting, well my preference is MIT as well; but it's up to maxogden to decide