search

max-mapper / torrent

download torrents with node from the CLI
https://www.npmjs.org/package/torrent
634 stars 78 forks source link

Added travis ci support for modern node versions #52

Closed amilajack closed 8 years ago

LinusU commented 8 years ago

I would personally prefer it if we dropped 5 here since it's not a maintained release line. Also, if it works on 4 and 6 than it probably works on 5 as well.

Thoughts?

btw. have we ever tried testing on 0.10? Maybe we should do that. I think that there are more people using 0.10 than 0.12 actually...

amilajack commented 8 years ago

I think that's fine. Doesn't make too much of a difference. Not sure why these old versions of node are still being used tho. They have older versions of v8 and lack ES6 support.

LinusU commented 8 years ago

Do you want to drop 5 as well?

amilajack commented 8 years ago

Lets keep it just in case there's some nasty bug that's only in node 5. Better safe than sorry? And it only adds a few minutes to the test.

LinusU commented 8 years ago

Fair enough 👍