search

max-mapper / voxel-engine

3D HTML5 voxel game engine
http://maxogden.github.com/voxel-engine
BSD 3-Clause "New" or "Revised" License
1.29k stars 220 forks source link

Add arrayTypeSize option, alternative to passing constructor in arrayType #95

Closed deathcap closed 9 years ago

deathcap commented 10 years ago

The 'arrayType' option allows the type of the array for voxels to be configured, but it requires passing a constructor - problematic in some situations since it cannot be directly JSON serialized. For example, voxel-client/voxel-server sends the voxel-engine settings over the network as JSON, or other modules may want to otherwise persist these settings, but arrayType: Uint16Array doesn't make it through.

So this PR adds an alternative option, arrayTypeSize - an easily-serializable integer, representing the number of bytes for the typed array (1, 2, or 4 for Uint8Array, Uint16Array, or Uint32Array, respectively).

kumavis commented 9 years ago

@deathcap do you have voxel-engine merge access? You're really carrying the project right now, so if not we would happily add you.

kumavis commented 9 years ago

This commit is included in #103