Closed gabehollombe closed 11 years ago
max-mapper
commented
11 years ago hmm I never use npm update since it is likely that versions of modules newer than those in package.json will break things. I just verified that with npm install from a fresh clone of the repo that it works
chrisekelley
commented
11 years ago I had the same problem. Trying switching to Chrome Stable; it works for me (24.0.1312.57 Macosx). In Chrome Beta and Canary, I was getting the same error (Uncaught TypeError: Type error) when the client was trying to send a message:
WebsocketStream.prototype.write = function(data, options) { return this.ws.send(data, options)
I created a version of voxel-server with an abbreviated version of its websocket code that may be useful for debugging: https://github.com/chrisekelley/voxel-server-test
max-mapper
commented
11 years ago weird, maybe the websocket api changed in chrome beta? the websocket repo is here https://github.com/maxogden/websocket-stream i'll look into it
max-mapper
commented
11 years ago ahha, the websocket API changed between chrome 24 and 25: https://github.com/webRTC/webrtc.io-client/commit/a1237813a4f26545a17a5626b132bafe71a29596
i'm fixing websocket-stream and pushing a new version, will update voxel-server to use the version as well
As of latest (d3a748a3a26f6b25e00fda6cc1b99e29168ae336)
I'm seeing 'Uncaught TypeError's in the console. Can you repro and, if so, is there something I should be doing to fix this? I'm nearly positive this was working the other say, so I suspect an updated version of a required NPM module may be the culprit, but who knows, could just be my box, so seeking confirmation of bug before we look into this...