max-mapper / websocket-stream

websockets with the node stream API
BSD 2-Clause "Simplified" License
667 stars 114 forks source link

Set `protocols` based on the field in `options` #103

Closed emallson closed 7 years ago

emallson commented 7 years ago

Resolves #102.

This sets the protocols variable based on the protocol field from the options object. I am not certain if this is the right field; it is the one used by mqtt.js which is what I need it for, but may not be generally the correct one.

mcollina commented 7 years ago

Does this solves your issues?

emallson commented 7 years ago

Yes, this PR works with the library and server in using.

On Nov 17, 2016 11:21 AM, "Matteo Collina" notifications@github.com wrote:

Does this solves your issues?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maxogden/websocket-stream/pull/103#issuecomment-261293028, or mute the thread https://github.com/notifications/unsubscribe-auth/AErpkl81bN0_RqAoKCP29HZM3kFA9a1Sks5q_H8PgaJpZM4K1fvW .