search

max-mapper / websocket-stream

websockets with the node stream API
BSD 2-Clause "Simplified" License
667 stars 114 forks source link

cork/uncork logic client fix #147

Closed scarry1992 closed 5 years ago

scarry1992 commented 5 years ago

@mcollina, if structure fixed. So, what do you think?

mcollina commented 5 years ago

I don't really understand why we can't use the same logic for Node as well.

scarry1992 commented 5 years ago

@mcollina, You can try to clone and remove last else block from upper code block and to run server tests. As I see lib use some destroy logic included in duplexify for server side using lib. Maybe I understood something wrong.

scarry1992 commented 5 years ago

@mcollina, Hello. Do you tried to rewrite w/o duplexify?

mcollina commented 5 years ago

Unfortunately I have no time atm :/

Il giorno mar 29 gen 2019 alle 17:20 scarry1992 notifications@github.com ha scritto:

@mcollina https://github.com/mcollina, Hello. Do you tried to rewrite w/o duplexify?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/maxogden/websocket-stream/pull/147#issuecomment-458604117, or mute the thread https://github.com/notifications/unsubscribe-auth/AADL437wgZa3iaBbqLnQjmc6XlTNgPj3ks5vIHTAgaJpZM4aWE8f .

scarry1992 commented 5 years ago

@mcollina, so what about that PR?

scarry1992 commented 5 years ago

@mcollina, do you release it in npm?

mcollina commented 5 years ago

Yes, v5.2.0.