search

max-mapper / websocket-stream

websockets with the node stream API
BSD 2-Clause "Simplified" License
667 stars 114 forks source link

v5.2.0 is breaking ... can't say exactly what #148

Closed binarykitchen closed 5 years ago

binarykitchen commented 5 years ago

This with your latest v5.2.0 breaking my www.videomail.io app - had to revert back to 5.1.2

Afraid I can't exactly say what it is.

binarykitchen commented 5 years ago

If it helps, objectMode is set to true and perMessageDeflate to false here

mcollina commented 5 years ago

Reverted in v5.3.0.

@scarry1992 can you please send the PR again?

scarry1992 commented 5 years ago

@mcollina, I remove my fork already. What going on?

mcollina commented 5 years ago

It seems your changes are breaking @binarykitchen. Your code is still available on https://github.com/maxogden/websocket-stream/commit/76ec47a8e8e1ddc253a050923b66977ab24ac6b3.

scarry1992 commented 5 years ago

ok then, I remake PR. But what case breaks my changes?

scarry1992 commented 5 years ago

@mcollina, https://github.com/maxogden/websocket-stream/pull/149. Ok?

binarykitchen commented 5 years ago

sorry guys, been busy. trying to give you more information here to reproduce:

  1. git clone https://github.com/binarykitchen/videomail-client
  2. run example with yarn start, all works fine
  3. bump websocket-stream dependency to 5.2.0
  4. try one example again, it fails, behaves differently (always connecting)

i've also opened console and can see a different sequence of events emitted

before (when it worked) it was

  1. resume, 2. uncork, 3. connect and then 4. data Screen Shot 2019-03-28 at 16 59 19

but after, with v5.2.0 it is

  1. resume, 2. connect and 3. preend (ends too early?) Screen Shot 2019-03-28 at 16 57 47

afraid cant tell more. but feel free to use this repo to reproduce the problem.

nuharaf commented 5 years ago

I am getting bunch of self is undefined and state is undefined using 5.30, work OK with 5.12. What I do is simply try to do mqtt.connect from mqttjs.

Screenshot from 2019-04-01 00-02-47

AlexStacker commented 5 years ago

After upgrading to 5.3.0, the version number of the readable-stream library used is 3.0, which makes mqtt not work properly. It seems that the process-nextick-args is removed. Can it be solved as soon as possible?

AlexStacker commented 5 years ago

By setting the webpack node environment variable is already ok QQ截图20190403170625

mcollina commented 5 years ago

Should be fixed in 5.4.0