search

max-mapper / websocket-stream

websockets with the node stream API
BSD 2-Clause "Simplified" License
668 stars 114 forks source link

Add typings, closes #144 #150

Closed benjamincburns closed 5 years ago

benjamincburns commented 5 years ago

Title says it all.

I've tested these typings for a few days over at trufflesuite/ts-lxd and they seem to work great.

mcollina commented 5 years ago

Can you add some verification of the types? ideally compiling a file would be enough.

benjamincburns commented 5 years ago

@mcollina sorry that I didn't see this until now. sure thing!

benjamincburns commented 5 years ago

Hopefully that'll do it - can set up a sample TS project if you like but this seemed nicely self-contained and didn't require me to extend/modify the way you're currently handling test execution.

mcollina commented 5 years ago

That’s ok. Having a simple file we can compile and check there are no regressions is ok.

benjamincburns commented 5 years ago

@mcollina did you need anything else from me before this can be merged?

mcollina commented 5 years ago

Nothing really, thank you!