search

max-mapper / websocket-stream

websockets with the node stream API
BSD 2-Clause "Simplified" License
667 stars 114 forks source link

Fix memory leak on NodeJS while using WebSocketStream #153

Closed vv-yakovlev closed 4 years ago

vv-yakovlev commented 4 years ago

WebSocket handlers like onerror, onclose, onmessage and onopen are accessible via setter/getter in NodeJS And setter first of all fires removeAllListeners, that doesnt make inner array of clients on WebSocketServer cleared ever

mcollina commented 4 years ago

5.5.2 is out

Il giorno mer 4 mar 2020 alle ore 17:30 vv-yakovlev < notifications@github.com> ha scritto:

When can i expect new version with this fix?)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/maxogden/websocket-stream/pull/153?email_source=notifications&email_token=AAAMXY6Q2QWWCJU7F5VG7ILRFZ6ZBA5CNFSM4LBBD4HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENYZBPA#issuecomment-594645180, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMXY7DVXZZJTGDVPVOSR3RFZ6ZBANCNFSM4LBBD4HA .