search

max-mapper / websocket-stream

websockets with the node stream API
BSD 2-Clause "Simplified" License
667 stars 114 forks source link

Update dependencies #160

Closed orgads closed 3 years ago

seriousme commented 3 years ago

@mcollina can someone please review and merge? E.g. the current 'ws' version 3.2.0 is 4 major versions behind and has a security vulnerability :-(

TIA, Hans

orgads commented 3 years ago

Updated to latest everything, including duplexify.

mcollina commented 3 years ago

Why do you think this module is worth maintaining? ws has direct support for Node streams now.

orgads commented 3 years ago

Oh, nice! I wasn't aware of it.

Thanks.

seriousme commented 3 years ago

If its not worth maintaining wouldn't it be more clear to (potential) users to mark it as deprecated on the home page and on NPM and point to ws instead ? That would stop people asking for updates and would warn people that still depend on it and don't know it is no longer maintained anymore. Having unmarked orphaned code imho weakens the security of the node ecosystem.