search

max-mapper / websocket-stream

websockets with the node stream API
BSD 2-Clause "Simplified" License
667 stars 114 forks source link

isn't an instance of stream.Readable #98

Closed NodeGuy closed 7 years ago

NodeGuy commented 8 years ago

Duplex streams in Node.js inherit from stream.Readable:

Since JavaScript doesn't have multiple prototypal inheritance, this class prototypally inherits from Readable, and then parasitically from Writable.

websocket-stream doesn't do this and I can't use it with generic functions that dispatch on type.

My desire is for websocket-stream to inherit from stream.Readable like duplex streams do in Node.js.

mcollina commented 7 years ago

I'm certain that any instance returned by websocket-stream is a duplex. Can you upload an example of what you are trying to achieve?

BTW, desires have little room in open source.

NodeGuy commented 7 years ago

I solved my problem a different way so I don't need this anymore, thank you.

What are you saying, pull requests carry more water than desires? ;-)