search

max-mapper / yo-yo

A tiny library for building modular UI components using DOM diffing and ES6 tagged template literals
1.33k stars 65 forks source link

Make rollupjs work #48

Closed Qard closed 8 years ago

Qard commented 8 years ago

Rollup.js seems to break when setting and then modifying an export like this. Modifying bel directly fixes the issue.

shama commented 8 years ago

Setting module.exports like we are currently is really common practice. This sounds like an issue with rollup.js.

Qard commented 8 years ago

I've filed an issue for it on rollup. It's a trivial fix here though, and probably a much more complex one over there, due to the ambiguity of whether something should be assigned to the named exports or the default object of an ES6 module.

Rich-Harris commented 8 years ago

FYI, have released a fix for rollup-plugin-commonjs

Qard commented 8 years ago

Thanks! I'll close this then. 😸