search

max-mapper / yo-yo

A tiny library for building modular UI components using DOM diffing and ES6 tagged template literals
1.33k stars 65 forks source link

Pin morphdom to 2.1 #61

Closed aknuds1 closed 7 years ago

aknuds1 commented 7 years ago

Pin morphdom to 2.1.x as 2.2 introduces regressions

yoshuawuyts commented 7 years ago

v1.3.2 :tada:

kristoferjoseph commented 7 years ago

Ah crap. What regressions?

yoshuawuyts commented 7 years ago

we've had 2 reports already and one that might be an issue, 1 was fixed already but the other's still there - reverting just to make sure :/

On Tue, Jan 10, 2017 at 5:32 PM kj notifications@github.com wrote:

Ah crap. What regressions?

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/maxogden/yo-yo/pull/61#issuecomment-271624531, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWlemWFZu_6N0bBH6Q8jmz5_pMOQElkks5rQ7KLgaJpZM4Lfddg .

aknuds1 commented 7 years ago

@kristoferjoseph The regression I was seeing was that selectedIndex is no longer set on select elements. I tried setting this both via selected attribute on option elements and selectedIndex on the select itself.

I haven't found out why the regression is happening, but going back to morphdom 2.1 helps.

kristoferjoseph commented 7 years ago

OK. Thanks for the info. Will take a look once I find time.

On Tue, Jan 10, 2017, 8:35 AM Arve Knudsen notifications@github.com wrote:

@kristoferjoseph https://github.com/kristoferjoseph The regression I was seeing was that selectedIndex is no longer set on select elements. I tried setting this both via selected attribute on option elements and selectedIndex on the select itself.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/maxogden/yo-yo/pull/61#issuecomment-271625580, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEqFAuU3QksfKXnxIj7bpf-EeKQeR64ks5rQ7NigaJpZM4Lfddg .