search

max-moser / lightdm-elephant-greeter

A simple LightDM greeter that can run under Wayland.
MIT License
61 stars 3 forks source link

Changes in my fork pushed to upstream #2

Closed ghost closed 1 year ago

ghost commented 2 years ago

I want to add more features and have already begun making some changes, I only forked it because I thought I had to.

zeGolem commented 1 year ago

Not the repo's owner, and i don't think this'll get merged, but for what it's worth, you should try to read up a bit on how to use git before contributing…

Your commits all have generic names, and no descriptions, and remove/add files seemingly randomly… You should use commits as a “package of changes”, so group all relevant changes in a single commit, and avoid typo correction kinds of commits in your pull requests (you should add them to the original commit)

Hope this helps :) have a nice day!