max / awesome-lint

awesome-lint as a GitHub Action
20 stars 5 forks source link

Problem with running action #1

Closed gep13 closed 5 years ago

gep13 commented 5 years ago

I am trying to fix all the awesome-lint errors that are appearing on this repository:

https://github.com/sdras/awesome-actions

I have been able to remove all of them, with the exception of this one, which appears when your GitHub Action is executed:

image

However, when I run awesome-lint locally, I get the following:

image

Looking at this rule:

https://github.com/sindresorhus/awesome-lint/blob/master/rules/git-repo-age.js

It looks like 'git' is a requirement. Is it possible that git isn't currently available on the docker image that you are using? Or, can you suggest another reason why this rule would be triggered for this repository?

Thanks

//cc @sdras

gep13 commented 5 years ago

@max just wanted to check in to see if you had any ideas about this. Thanks

max commented 5 years ago

@gep13 Thank you for digging into this. I was able to verify that it’s indeed because of the missing git dependency. I tried out #2 against sdras/awesome-actions and everything now passes.

Pro tip: If you want to debug GitHub Actions locally check out nektos/act.

I hope you have a great weekend!

gep13 commented 5 years ago

@max thanks for getting this fixed!

max commented 5 years ago

No problem. I also cut a release fo if you would like to pin the Action to @1.0.0 instead of @master that should work as well.

On Sat, Mar 2, 2019 at 10:50 AM Gary Ewan Park notifications@github.com wrote:

@max https://github.com/max thanks for getting this fixed!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/max/awesome-lint/issues/1#issuecomment-468948867, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG0Dwcse5iMhiSqeVLcYb46AKOvhon5ks5vSsgSgaJpZM4bVmvM .

gep13 commented 5 years ago

I can confirm that this is now working:

image

Thanks again for your help in getting this fixed!