search

max0x7ba / atomic_queue

C++ lockless queue.
MIT License
1.47k stars 176 forks source link

mention vcpkg package #29

Closed mheyman closed 3 years ago

mheyman commented 3 years ago

In the Using the library section, you can mention that atomic_queue is available via vcpkg. For example:

$ ./vcpkg install atomic-queue

FYI: the vcpkg port is pretty simple: https://github.com/microsoft/vcpkg/tree/master/ports/atomic-queue

max0x7ba commented 3 years ago

Added that to the documentation, thank you.

IMO, it would be least surprising if vcpkg port had exactly the same name - atomic_queue (with an underscore, not a dash).

mheyman commented 3 years ago

Yes, it would be less surprising. Unfortunately, vcpkg is opinionated about package names and doesn't allow underscores :-(

max0x7ba commented 3 years ago

Yes, it would be less surprising. Unfortunately, vcpkg is opinionated about package names and doesn't allow underscores :-(

Oh, I didn't know that.

max0x7ba commented 1 year ago

In the Using the library section, you can mention that atomic_queue is available via vcpkg. For example:

$ ./vcpkg install atomic-queue

FYI: the vcpkg port is pretty simple: https://github.com/microsoft/vcpkg/tree/master/ports/atomic-queue

vcpkg_from_github parameters REF and SHA512 refer to an old version and that concerns me.

I am unfamiliar with vcpkg and unsure what these parameters are used for. Reading vcpkg_from_github documentation, these parameters are optional. Would it make sense to remove them, so that your port tracks the latest version from master/HEAD?

max0x7ba commented 2 weeks ago

I wonder what is the process to keep the vcpkg package updated whenever there is a new version of this library in github, please?