search

max0x7ba / atomic_queue

C++ lockless queue.
MIT License
1.47k stars 176 forks source link

Use of if constexpr inside AtomicQueueCommon methods #70

Closed HerikLyma closed 3 months ago

HerikLyma commented 3 months ago

In several places, we have the following check:

if (Derived::spsc_)

However, this check is performed at runtime.

The proposal is to replace it with:

if constexpr (Derived::spsc_)

This way, the check will occur at compile-time, making AtomicQueueCommon even faster.

max0x7ba commented 3 months ago

However, this check is performed at runtime.

Show assembly output where this check is performed at run-time. And show assembly output with your proposed changes which eliminates that check.

max0x7ba commented 3 months ago

Feel free to re-open your pull request when you can demonstrate that your claims correspond to reality.

max0x7ba commented 3 months ago

Feel free to re-open your pull request when you can demonstrate that your claims correspond to reality.

No, not interested in help on that project anymore. Too much arrogance here, sorry.

You should respond with evidence proving your claims, rather than this childish tantrum of yours.