max22- / ESP32-BLE-MIDI

An Arduino library to use Midi over BLE (Bluetooth Low Energy), on ESP32 boards
MIT License
214 stars 27 forks source link

library.json: add ESP32 ble library dependency #19

Closed nicola-lunghi closed 1 year ago

max22- commented 1 year ago

I don't think it's needed to add ESP32 BLE Arduino library as a dependency because it is already included in the Arduino core as mentioned here : https://github.com/nkolban/ESP32_BLE_Arduino

nicola-lunghi commented 1 year ago

Hi,

I think the Arduino library has a different header

See here:

https://forum.arduino.cc/t/ble-arduino-esp32-which-library-should-i-use/893303 -https://www.arduino.cc/reference/en/libraries/arduinoble

Apparently the library is called ArduinoBLE.h

include

In platformio I had to add the other library to make it compile.

Thanks, Nick

On Mon, 26 Dec 2022, 23:45 Maxime ANDRÉ, @.***> wrote:

I don't think it's needed to add ESP32 BLE Arduino library as a dependency because it is already included in the Arduino core as mentioned here : https://github.com/nkolban/ESP32_BLE_Arduino

— Reply to this email directly, view it on GitHub https://github.com/max22-/ESP32-BLE-MIDI/pull/19#issuecomment-1365493734, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGB6YTEN2DTYKMAMJ3JD653WPINYDANCNFSM6AAAAAATJ5LLJA . You are receiving this because you authored the thread.Message ID: @.***>

max22- commented 1 year ago

I have used only the ESP32 Arduino core, and Platformio to code this library. There is no need to add ESP32_BLE_Arduino in the dependencies.

Btw, i released a new version this morning which is based on NimBLE (which is way more lightweight). If you want to check it out. (and now there is a dependency on NimBLE-Arduino).