search

max2ma / FinancialModels_AmazonF1

Apache License 2.0
16 stars 9 forks source link

Fixed point version #3

Open Mahdi89 opened 6 years ago

Mahdi89 commented 6 years ago

Hi, I have a data type fix for the fixed-point version (my handle is Mahdi89). I understand that fixed-point simulation takes longer to converge but afaik it utilises resource better and its integer/fraction ratio could be explored based on the input data.

Thanks

lavagno commented 6 years ago

Thanks! I will let Liang Ma, the actual application developer, reply about how he would like you to contribute to the project. Best regards, Luciano Lavagno

On Fri, 04 May 2018 04:37:04 -0700 Mahdi Jelodari notifications@github.com wrote:

Hi, I have a data type fix for the fixed-point version (my handle is Mahdi89). I understand that fixed-point simulation takes longer to converge but afaik it utilises resource better and its integer/fraction ratio could be explored based on the input data.

Thanks

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/KitAway/FinancialModels_AmazonF1/issues/3

-- EU Cell +39-334-6170661 US Cell +1-510-5868174 Office +39-011-0904150 http://www.det.polito.it/personale/scheda/%28nominativo%29/luciano.lavagno Politecnico di Torino, Corso Duca degli Abruzzi 24, 10129 Torino, Italy

max2ma commented 6 years ago

Hi Mahdi89, Do you have your code ready now? If you like, I could add you as a collaborator so that you can contribute to this repo directly. Or you could make a fork from this repo, make your modification and then send a merge request. Hope you see your contribution. Best regards, Liang

Mahdi89 commented 6 years ago

Hi Liang, Thanks for your reply, Sure, I have couple of PRs for getting fixed point in, which I think would be easier to submit them as separate PRs and you can review them separately and merge into master after review. My handle is Mahdi89. Thanks