Closed Sam-programs closed 3 months ago
tell me when you're done with the todos so I can then take another quick look and merge looks really nice so far 👍
tell me when you're done with the todos so I can then take another quick look and merge
I am gonna do the todos in other prs after this is merged, so that we can revert the individual prs without reverting this one.
looks really nice so far 👍
Thanks.
so this would be good to merge as is from your side?
Yes.
Of course, I messed up the branch, and now, it has a million duplicated commits.
seems like a messed up rebase imo the simplest would be to just go there, copy the whole file, create a new branch from master, past, commit, open new pr
imo this change isn't so big that the history would be important
Since there were some bugs recently, and the code was hard to read, I decided to review it and
Add more comments to make the code
humanmore readableRenamed
key
tofirst_key
Renamed
subkey
tosecond_key
Renamed
recorded_key
tohas_recorded
Renamed
last_key
torecorded_key
Renamed
parent_keys
tosequences
Renamed
sequence_timer
totimeout_timer
Renamed
log_key
torecord_key
Removed a useless check in
record_key
Inverted the condition in
vim.on_key
to make it easier to readTODO: fix: clear_mappings' position (Currently, it clears the mappings of the new config, not the old config) TODO: move pcall to be inside of clear_mappings, so that it doesn't crash(stop deleting mappings) if mapping gets deleted twice (it gets deleted twice when it's a startkey and an endkey). TODO: remove
sequences
because we can use thesettings.mappings
table instead. I will do theTODO:
s in other prs later.@max397574, Since this is a breaking change for all other prs, if you are working on the plugin right now, don't merge this.