search

max397574 / care.nvim

care.nvim - Completion And Recommendation Engine for Neovim - WIP
https://max397574.github.io/care.nvim/
GNU General Public License v3.0
100 stars 9 forks source link

feat: add new api function `get_index` #86

Closed matthis-k closed 2 months ago

matthis-k commented 2 months ago

This is the PR for issue #85 (your 3rd solution).

Maybe I will do the 1st one later but i want to get some other things done first.

I do not think this needs extensive testing, so it is a really small PR

max397574 commented 2 months ago

🙈 promise this will be the last thing for such a small pr could u update the commit body to include fixes https://github.com/max397574/care.nvim/issues/85 just so we have that linked there (and also remove the change from has_selection thing)

really sorry that this small change required so much changing

Really happy to get a first contributor to the project 🎉

matthis-k commented 2 months ago

No worries, I really should care more about better wording/docs when I code something not for me. I tend to go to fast and have to fix up for hours later (while not in an actually planned project). Maybe its good to sometimes get reminded of that :wink:

max397574 commented 2 months ago

well this is one of the biggest projects I've done so far so I put quite a big emphasis on documentation of things and also other stuff

as e.g. pointed out above that the commits and issues are linked together after you've made that change we can merge this pr

matthis-k commented 2 months ago

I just got food and forgot it, a classic move.