search

maxammann / trello-to-deck

trello-to-deck reads from an JSON export of Trello and creates a board in Nextcloud Deck.
MIT License
66 stars 9 forks source link

Add None color to colormap #16

Closed connorjward closed 3 years ago

connorjward commented 3 years ago

I was getting a KeyError when setting the label colour which Trello permits to be None. I've extended the color_map to account for this (although a try, except block would also be good here).

maxammann commented 3 years ago

Thanks for the PR!

Should we maybe use the nextcloud blue as the fallback? #0082c9

connorjward commented 3 years ago

Ok I've pushed that. I used "default" as the key because it's a lot more expressive than None. This will affect the other PR though...

I also expanded where you form the labels list to make the try + except more explicit.

maxammann commented 3 years ago

Thanks for the contribution!