search

maxandriani / ngx-google-analytics

An easy way to use and configure Google Analytics on Angular 6+ applications
MIT License
120 stars 49 forks source link

Multiple tracking codes #105

Open samuelrajsams opened 1 year ago

samuelrajsams commented 1 year ago

How can we pass multiple google tracking codes ?

I want to pass as before NgxGoogleAnalyticsModule.forRoot('UA-175593006-2', 'UA-175593006-1' )

lordnino commented 1 year ago

@maxandriani I would like to work on this feature if it's possible

maxandriani commented 1 year ago

Hello Ali!

I'm glad you want to help on this library and feel free to contribute.

Just keep in mind that people don't like breaking change features and every new functionality should keep our previous APIs working.

There is one other issue, I'm investing almost all my free time with a Master's Degree and I don't have much time to maintain this library. So before any new features it's necessary to upgrade to the recent angular versions. Does upgrades are a pain in the ass because you need to deliver a pull request to each angular major version.

There is also another issue that came to my attention, it seems like Google Analytics has changed the ga.js to another tag engine. I believe this could impact the issue you want to work on.

In short, you have my permission to work on this project, but, these are the quality requirements to deliver new versions.

Em seg., 25 de set. de 2023 às 21:01, ali Badr @.***> escreveu:

@maxandriani https://github.com/maxandriani I would like to work on this feature if it's possible

— Reply to this email directly, view it on GitHub https://github.com/maxandriani/ngx-google-analytics/issues/105#issuecomment-1734625936, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWEQ5ZJGF7MVFICJAIZ2R3X4ILNFANCNFSM6AAAAAAR73OOIU . You are receiving this because you were mentioned.Message ID: @.***>

-- Maxmiliano Andriani Arquiteto de Software (47) 9 9606-9134 www.maxandriani.art.br http://www.maxandriani.art.br

hakimio commented 1 year ago

@maxandriani I have forked the library and published a version which works with GA4 and Angular 16. Release announcement Installation and usage Let me know what you think about it.