maxbanton / cwh

Amazon Web Services CloudWatch Logs Handler for Monolog library

MIT License

417 stars 84 forks source link

fix AWS Limits Race-Condition #113

Closed digitalkaoz closed 1 year ago

digitalkaoz commented 1 year ago

BugFix

fix initializing phase by sending logs to buffer during initialization by introducing a second variable initializing so subsequent log calls wont call the initialize phase again.

Update

removed deprecated sequenceToken
added proper typehints (might break php7, but its deprecated anyways)

fixes #111 fixes #86

its definitly a BC break, so a new major version would be needed

digitalkaoz commented 1 year ago

well actually it doesnt solve the problem in reality. the solutions was to disable createGroup and create the group & stream proactivly.

Remember PHP is stateless, so every Requests kicks on the Describe Groups Stuff which raises the RateLimitException on heavy load