Incompatible with most recent Monolog version? PHP Fatal Error with getDefaultFormatter()

[dustinbolton]

• I'm submitting a ...

  • [ X ] bug report
  • [ ] feature request
  • [ ] support request

• Do you want to request a feature or report a bug? Bug

• What is the current behavior? Does not work. Gives error: [27-Apr-2018 21:52:17 America/Chicago] PHP Fatal error: Declaration of Maxbanton\Cwh\Handler\CloudWatch::getDefaultFormatter() must be compatible with Monolog\Handler\AbstractProcessingHandler::getDefaultFormatter(): Monolog\Formatter\FormatterInterface in /site/classes/Maxbanton/Cwh/Handler/CloudWatch.php on line 10

• Please tell about your environment:

  • PHP Version: 7.1.12
  • Operating system (distro): Mac OS High Sierra 10.13.3
  • Application mode (web app / cli app / daemon cli app): web app
  • Monolog version 1.23.0

[maxbanton]

Hi @dustinbolton. Can not reproduce described issue. Do you use any framework? Could you show your handler configuration?

[dustinbolton]

I narrowed down the problem to being related to using my own autoloader rather than composer. I'm not using a framework but using an autoloader as suggested in https://github.com/Seldaek/monolog/issues/265

I was able to get this to work by modifying your CloudWatch.php as follows to make the function match more exactly. Do you think this is an acceptable fix?

Inserted at line 9: use Monolog\Formatter\FormatterInterface;

Changed line 331 from: protected function getDefaultFormatter() to protected function getDefaultFormatter(): FormatterInterface

[maxbanton]

Hi @dustinbolton! This kind of change will make Handler incompatible with PHP versions lower then 7.0 and it is unacceptable for now. PHP 5.6 is still used by 16% of packagist.org users. I plan to drop old PHP version support by the end of the year.

Max.