maxbanton / cwh

Amazon Web Services CloudWatch Logs Handler for Monolog library
MIT License
417 stars 84 forks source link

Added option to disable creating the log group #75

Closed guillaumesmo closed 4 years ago

guillaumesmo commented 4 years ago

Please let me know what you think about it.

Alternatively, I propose to make the initialize and refreshSequenceToken methods protected, because currently there's no way to achieve my change by extending the class, so copy-pasting the whole class is the only solution.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.5%) to 91.515% when pulling cb6e851352eebae7073966ba30ed65144c6da1c8 on guillaumesmo:disable-create-group into e9bc1f253663388c3555fbab0414ce82af97ee3a on maxbanton:master.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.02%) to 91.975% when pulling 765089661d41477812ef8f830cc5ce122bc03f2a on guillaumesmo:disable-create-group into e9bc1f253663388c3555fbab0414ce82af97ee3a on maxbanton:master.

maxbanton commented 4 years ago

Hi @guillaumesmo! Thanks for your PR. Nice point about reducing security boundaries, I like it. What about adding your option to the constructor?

Regards, Max.

guillaumesmo commented 4 years ago

Hello @maxbanton

I was thinking about doing that first but since the constructor already has plenty of arguments I preferred not to

I'll update my branch

guillaumesmo commented 4 years ago

Hi @maxbanton

Any news if this could be merged?

Thank you

maxbanton commented 4 years ago

Hi @guillaumesmo! You PR is merged now and new version v.1.1.14 is published.

guillaumesmo commented 4 years ago

Thank you, and happy new year ;)