maxbbraun / accent

Accent Smart Picture Frame
https://accent.ink
MIT License
199 stars 16 forks source link

Waveshare HD display support #12

Closed HalfdanJ closed 3 years ago

HalfdanJ commented 4 years ago

Hi Max, I was very inspired by your project and wanted to build one myself (and make some custom screens for it) so went ahead and got the pieces for it. The screen you are using (640x384) is discontinued, so went ahead buying the new v2 HD screen (880x640) thinking "how hard can it be to scale up". This PR contains all the changes I needed to make.

The new screen is controlled quite differently, so split it out into a new display "driver". But I was able to make it support the same image format you used for your display.

I added a &width=<WIDTH>&height=<HEIGHT> to all the server endpoints, allowing dynamic resolution. All the endpoints have been modified to support higher resolution, though the artwork and city ones are just centering the image, not scaling them up.

maxbbraun commented 4 years ago

Thank you and sorry for the slow reply! :) I haven't had a chance to try out this and the other pull request, but it's something I still want to do.

HalfdanJ commented 4 years ago

No worries! I'm seeing some periodic crash of the device. Not sure yet if its due to this PR or any of the other experiments i've done. Could be these larger images are using too much memory somewhere. Planning to debug it more.

maxbbraun commented 3 years ago

This turned out to be a little more involved to make sure all the content renders correctly at different resolutions. I implemented it in 9868d1da35801458c72f2fb4c08cf8ae0a589f81 (client) and 7fabe9830e070ddc5aefc2809908bd801c68a13c (server). It works for the 800x480 display now and adding support for other sizes should be easier too.