search

maxbbraun / trump2cash

A stock trading bot powered by Trump tweets
https://trump2cash.biz
MIT License
6.25k stars 855 forks source link

Document which direction you are trading in based on sentiment #24

Open markstos opened 7 years ago

markstos commented 7 years ago

It's not clear from the current docs whether you buy or sell stock for a company that Trump complains about.

You should state your bias about your expectation about Trump's tweets effect on stock prices. (Note that Nordstorm stock went up after Trump complained about them).

Se1ecto commented 7 years ago

Perhaps it depends on whether or not he actually has the political power to follow his tweets?

BernsteinA commented 7 years ago

It may not be in the docs but it's right there in trading.py

Cozen-Official commented 7 years ago

@markstos it's all in here

https://github.com/maxbbraun/trump2cash/blob/master/benchmark.md

markstos commented 7 years ago

It should be in the README. If you are going to bet money on someone's advice, it's important to know upfront whether you are betting for or against the advice!

domingohui commented 7 years ago

@markstos You meant we should document what the bot should do following a Trump's tweet? e.g. (in README would be) if Trump says good things about a company, then the bot will go long on the company, and vice versa.

from README

automatically executes trades on the relevant stocks according to the expected market reaction

I agree this is a bit ambiguous, but not quite when it comes to Trump the President :D

markstos commented 7 years ago

Exactly.

On Mon, Feb 13, 2017 at 12:04 AM, Domingo notifications@github.com wrote:

@markstos https://github.com/markstos You meant we should document what the bot should do following a Trump's tweet? e.g. (in README) "if Trump says good things about a company, then the bot will go long on the company, and vice versa."

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/maxbbraun/trump2cash/issues/24#issuecomment-279295372, or mute the thread https://github.com/notifications/unsubscribe-auth/AABk5Ri1GioV3WKnemaYjWP0Qb91_qmtks5rb-RlgaJpZM4L9fsA .

-- Mark Stosberg Senior Systems Engineer RideAmigos

BernsteinA commented 7 years ago

@markstos if you are going to run an open source bot that spends your own money, you should check out the code and not just trust the readme anyway :p