search

maxbbraun / trump2cash

A stock trading bot powered by Trump tweets
https://trump2cash.biz
MIT License
6.25k stars 855 forks source link

Generate historical market_data on the fly. #32

Open zgohr opened 7 years ago

zgohr commented 7 years ago

If historical market data isn't found during testing/benchmarking, generate it using the TradeKing API.

A better approach might be to just use the API for benchmarking. Is there a hard requirement that market data be stored locally?

maxbbraun commented 7 years ago

I actually did that first, but removed it because the data from the API gets less accurate (less granular) over time.

zgohr commented 7 years ago

Alright. Is there anything you'd like me to do with this PR? I built it to fetch historical prices when benchmarking strategies that included other twitter accounts (@potus, etc.) It might still have value in that capacity.

maxbbraun commented 7 years ago

I'm not planning to merge this pull request, but thank you for the suggestion!

I suspect that the right way to make getting historical market data better would be to use an API that returns high-quality results, even for older data. Something like that would likely cost money.

PhillGeorge commented 7 years ago

Does it integrate with any trading api's such that trades can be automatically triggered once a pair/stock is mentioned by potus ?