search

maxbeatty / hubot-uber

Hubot script to get Uber estimates
MIT License
11 stars 1 forks source link

Allow user to specify output format #4

Closed stephenyeargin closed 8 years ago

stephenyeargin commented 8 years ago

The default cli-table implementation does not look great when using a non-fixedwidth font (as is the case in many IRC clients and in Slack). This PR introduces a format abstraction that switches based on a HUBOT_UBER_OUTPUT_FORMAT. It will default to unformatted (splits the values with a / when listing them).

Fixes #3

maxbeatty commented 8 years ago

Looks good. Any chance you could include a screenshot of the different formats? That'd be a big help for people deciding on which option to use.

stephenyeargin commented 8 years ago

These look fine? Not sure how to present them in the README. Seems overkill to include them as part of the repository (could likely refer to the screenshots below as they aren't time-based).

none (the new default)

screen shot 2015-12-20 at 9 37 59 pm

slack format

screen shot 2015-12-20 at 9 37 11 pm

table format

screen shot 2015-12-20 at 9 41 38 pm

maxbeatty commented 8 years ago

Thanks for attaching those. These should be good enough for people looking for examples. (If not, they can open another PR :smile:) Look for this shortly as v2.0.0