search

maxbec / hassio-diyHue

Fully configurable diyHue add-on for home-assistant.
30 stars 17 forks source link

Allow us to configure whether to start the https server #11

Closed foxy82 closed 3 years ago

foxy82 commented 3 years ago

EDIT: UPDATED

I have now found the location of the diyhue config folder - it sits in a folder called diyhue alongside the Home Assistant configuration.yaml. As such I've made this PR only "no server https"

ORIGINAL PR comment

So this PR does two things.

1) removes the config_dir from the configuration options instead we use /data/config/diyhue. /data is the hassio persisted storage (/usr/share/hassio/addons/data/457625a0_diyhue-beta/config/diyhue) this means you can then access it on your host system in... /usr/share/hassio/addons/data/457625a0_diyhue-beta/config/diyhue

2) Add a config option no_serve_https this will stop diyhue starting a web server on port 443 which stops the OSError: [Errno 98] Address in use error if you run your home assistant on port 443

I made the changes initially to the diyHue-beta area but didn't realise that wasn't the one that the addon repo loads so I've put these changes in both.

foxy82 commented 3 years ago

Reverted the config file change so that this PR now just implements no-serve-https

foxy82 commented 3 years ago

I suggest squashing these on merge I had to do all the changes via github but i've tested them on my machine.

maxbec commented 3 years ago

Thank you @foxy82. Merged!