maxbec / openHAB-Alignment-Tool

This extension adds support for formatting and indenting openHAB files. At the moment only the item-files are supported.
https://marketplace.visualstudio.com/items?itemName=max-beckenbauer.oh-alignment-tool
Eclipse Public License 2.0
21 stars 4 forks source link

Format Document (Shift+Alt+F) does nothing #22

Closed DoganM95 closed 4 years ago

DoganM95 commented 4 years ago

Expected Behavior

Clicking the right click menu item "Format Document" or alternatively pressing Shift+Alt+F should format the document.

Instead there is an additional Context menu entry "Reformat File" which seems redundant, because its functionality could be transferred to "Format Document", to enable other extensions to perform additional actions (e.g. on each save, my code is automatically formatted by executing "Format Document", which in this case does not work).

Current Behavior

Clicking the "Format Document" context menu entry does nothing.

Steps to Reproduce (for Bugs)

  1. Create a valid .stiemap file with working content
  2. Right-click -> Format Document or Format document with... openHAB

Your Environment

towo commented 4 years ago

Duplicate of #8; relevant documentation would by the way be https://code.visualstudio.com/blogs/2016/11/15/formatters-best-practices. Implementation would make this extension work like magic™.

maxbec commented 4 years ago

Fixed: 80f4d2f14809e97df6573ac75435217718f14e3d

New Beta: https://github.com/MaxBec/openHAB-Alignment-Tool/releases/tag/v2.0.0-beta.1