search

maxbeizer / ueberauth_heroku

Elixir oauth strategy using Heroku
https://hex.pm/packages/ueberauth_heroku
MIT License
3 stars 1 forks source link

default_scope config is not being used #3

Closed rschooley closed 5 years ago

rschooley commented 6 years ago

I have the following configuration, but it does not change the requested token scope, it is always asking for identity.

config :ueberauth, Ueberauth,
  providers: [
    heroku: {Ueberauth.Strategy.Heroku, [default_scope: "global"]}
  ]

Appending the url args for ?scope= works.

I also notice that using the url method above still has scopes: [""]. Is that heroku just not spitting those values back, or is there a mapping issue in ueberauth_heroku / ueberauth?

maxbeizer commented 5 years ago

hi @rschooley . I'm sorry I never saw a notification for this issue. I'd be happy to have a look asap

maxbeizer commented 5 years ago

@rschooley sorry but I was unable to reproduce the issue you describe. I set up the example repo (which was a trip down memory lane). I ran it with the default config and it used the identity scope. I updated the config to global and restarted my server and I saw the below:

screen shot 2019-01-14 at 7 43 18 pm

Again sorry you had trouble with this. Did you remember to restart your server after changing config values?

I'm going to close this issue but feel free to reopen if you have a way I can reproduce.